feat(identity): add identity scaffolding and CRUDL operations for api key#1811
Open
nborges-aws wants to merge 2 commits into
Open
feat(identity): add identity scaffolding and CRUDL operations for api key#1811nborges-aws wants to merge 2 commits into
nborges-aws wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1811 +/- ##
============================================
+ Coverage 93.94% 94.11% +0.16%
============================================
Files 122 130 +8
Lines 6462 6648 +186
============================================
+ Hits 6071 6257 +186
Misses 391 391 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds identity scaffolding, as well as command-line CRUDL for Identity API key credential providers:
identity api-key-credential-provider createidentity api-key-credential-provider getidentity api-key-credential-provider listidentity api-key-credential-provider updateidentity api-key-credential-provider deleteFollows the structure established by harness and runtime for commands. Create/update accept
--nameand--api-key, get/delete accept justname, list accepts--max-resultsand--next-token. Similar to runtime, identity will appear in the TUI command menu at the root, but prints help pending TUI routing.Additional change to move generic default help handler created for runtime to
src/handlers/help.tsxto avoid duplication. This PR updates runtime call sites to point to new help handler.Testing
Tested via fixture tests against live AWS resources, as well as manual dogfooding via running the build artifact in CLI.
Related Issue
N/A
Type of Change
Testing
Verified from current HEAD:
Additional verification:
The committed identity fixtures were recorded with
RECORD=1against a live account in us-west-2. The RECORD run creates two providers (agentcore-cli-identity-fixture, agentcore-cli-identity-fixture-2), exercises pagination, then deletes both. The fixture set contains no credential material (API key values are not returned by the service).Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.